CI runs once, and never cancels a commit on main - #83
Merged
Conversation
The same change storage and spin-machine took, and here it fixes a failure that has been read as flakiness. An unfiltered `push:` fires alongside `pull_request:` for every push to a branch with one open, so every push started two identical runs. The concurrency group killed one, after both had already started — and on a self-hosted runner that is not merely a wasted runner: the two integration jobs install the same release and restart the same containerd on the same machine, so the loser fails during setup with something unrelated-looking. "ctr: error stating device path: stat /dev/disk/by-label" was the one that led here. One of the pair passed and the other went red, which reads as a flaky test and is not. And nothing cancels a run on main any more: two merges landing close together used to leave the first with no verdict. What is given up: a branch with no pull request open is not tested. That is what opening one is for. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_019GHRRFvbnZi5q3KSTvyW5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same change storage and spin-machine took. Here it also fixes a failure that has been read as flakiness.
An unfiltered
push:fires alongsidepull_request:for every push to a branch with one open, so every push started two identical runs. The concurrency group killed one — after both had already started, which on a self-hosted runner is not merely a wasted runner: the two integration jobs install the same release and restart the same containerd on the same machine, so the loser fails during setup with something unrelated-looking.ctr: error stating device path: stat /dev/disk/by-labelwas the one that led here. One of the pair passed and the other went red, which reads as a flaky test and is not.And nothing cancels a run on main any more: two merges landing close together used to leave the first with no verdict.
What is given up: a branch with no pull request open is not tested. That is what opening one is for.
🤖 Generated with Claude Code
https://claude.ai/code/session_019GHRRFvbnZi5q3KSTvyW5a